feat(mysql-cdc): support ssl.mode to allow configure the ssl behavior
#16579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
changed the title
ssl.mode to allow disable sslssl.mode to allow configure the ssl behavior
KeXiangWang
approved these changes
May 4, 2024
neverchanje
reviewed
May 5, 2024
| @@ -250,7 +249,7 @@ pub struct ExternalTableConfig { | |||
| #[serde(rename = "table.name")] | |||
| pub table: String, | |||
| /// `ssl.mode` specifies the SSL/TLS encryption level for secure communication with Postgres. | |||
| /// Choices include `disable`, `prefer`, and `require`. | |||
| /// Choices include `disabled`, `preferred`, and `required`. | |||
There was a problem hiding this comment.
Just an FYI: 😄
disable/prefer/require actually uses the naming convention from PG, although it may look like a grammar mistake. I guess the intention was to give shorter names to these options.
There was a problem hiding this comment.
Yeah, I know. The ssl.mode is just a interface to the end users, and mysql uses disabled, preferred, and required which have same semantic as PG. So I decide to unify the naming.
There was a problem hiding this comment.
This is a breaking change...
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
ssl.modeto allow user configure the ssl behavior (ref)related: #15690
Checklist
./risedev check(or alias,./risedev c)Documentation
Updated by @neverchanje
This PR involves a change on Postgres connector. It rename the values of
ssl.modefrom "disable, prefer, and require" to "disabled, preferred, and required".On the other hand, the
ssl.modeoption is also supported for the MySQL connector, enabling a SSL/TLS encrypted connection to the upstream MySQL.Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.