Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres-cdc): disable certificate verification for prefer and require #16319

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Apr 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

A quick solution to #16316

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW requested review from jetjinser and zwang28 April 16, 2024 04:13
@github-actions github-actions bot added the type/fix Bug fix label Apr 16, 2024
@kwannoel
Copy link
Contributor

Need cherry-pick to 1.8?

@StrikeW
Copy link
Contributor Author

StrikeW commented Apr 16, 2024

Need cherry-pick to 1.8?

Didn't evaluate the effectiveness yet, I think there is only one user waiting for this patch. IMO we can proceed the 1.8.1 release without waiting for this one, WDUT? @zwang28

@StrikeW StrikeW enabled auto-merge April 16, 2024 06:49
@StrikeW StrikeW added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit b5ec2ae Apr 16, 2024
40 of 41 checks passed
@StrikeW StrikeW deleted the siyuan/pg-cdc-tls branch April 16, 2024 07:37
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants