Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(allocator): remove things related to task_local_alloc #15976

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Mar 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Task local alloc is disabled since #9241 and seems we don't have any plan to re-enable it. Code has been out of date.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc requested a review from a team as a code owner March 28, 2024 07:19
@stdrc stdrc requested a review from BugenZhao March 28, 2024 07:19
@stdrc stdrc requested review from TennyZhuang and fuyufjh March 28, 2024 07:20
@stdrc stdrc added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit af11697 Mar 28, 2024
29 of 30 checks passed
@stdrc stdrc deleted the rc/remove-task-local-alloc branch March 28, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants