Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): support time travel for iceberg source #15866

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Mar 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Example

-- FOR SYSTEM_TIME AS OF [STRING | NUMBER] 
-- the timestamp should be a format like [YYYY-MM-DD HH:MM:SS] or an unix timestamp in second
select * from s for system_time as of '2100-01-01 00:00:00+00:00';
select * from s for system_time as of 4102444800;

-- FOR SYSTEM_VERSION AS OF [SNAPSHOT_ID]
select * from s for system_version as of 3023402865675048688;

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

src/connector/src/source/iceberg/mod.rs Outdated Show resolved Hide resolved
@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Mar 25, 2024
@chenzl25 chenzl25 requested review from fuyufjh and BugenZhao March 26, 2024 05:33
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/connector/src/source/iceberg/mod.rs Outdated Show resolved Hide resolved
let snapshot = snapshots
.iter()
.filter(|snapshot| snapshot.timestamp_ms <= timestamp)
.max_by_key(|snapshot| snapshot.timestamp_ms);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note down an idea during offline discussion with @chenzl25:

We might offer an option to read the latest compacted (i.e. doesn't contain delete files) snapshot. This is because it seems difficult for users to figure out the correct timestamp to read.

@chenzl25 chenzl25 enabled auto-merge March 26, 2024 08:05
@chenzl25 chenzl25 added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 3607db5 Mar 26, 2024
27 of 29 checks passed
@chenzl25 chenzl25 deleted the dylan/support_time_trave_for_iceberg_source branch March 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants