feat(connector): add SSL support for external cdc postgres connector #15690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Mar 15, 2024
neverchanje
reviewed
Mar 15, 2024
stdrc
reviewed
Mar 15, 2024
xxchan
changed the title
StrikeW
reviewed
Mar 18, 2024
only when sslmode is disable, we should use NoTls, and we should use Tls when sslmode is prefer or require.
jetjinser
force-pushed
the
jinser/connector-ssl
branch
from
fe97503 to
46a9074
Compare
jetjinser
force-pushed
the
jinser/connector-ssl
branch
from
3b7f71f to
749e38c
Compare
neverchanje
added
user-facing-changes
jetjinser
force-pushed
the
jinser/connector-ssl
branch
from
6b2e163 to
53a0290
Compare
neverchanje
approved these changes
Mar 28, 2024
|
PTAL cargo.toml @stdrc @BugenZhao |
stdrc
approved these changes
Mar 28, 2024
jetjinser
added a commit
that referenced
this pull request
Mar 28, 2024
…15690) Co-authored-by: Tao Wu <[email protected]> Co-authored-by: StrikeW <[email protected]>
9 tasks
StrikeW
reviewed
Apr 15, 2024
|
|
||
| impl Default for SslMode { | ||
| fn default() -> Self { | ||
| Self::Prefer |
There was a problem hiding this comment.
We should set the default value to Disable which is same as before for backward compatible. Then for upstreams that require TLS, the user should set ssl.mode='require'.
This was referenced Apr 15, 2024
9 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #14646.
Introduce dependency:
postgres-openssl: https://docs.rs/postgres-openssl/latest/postgres_openssl/.Checklist
./risedev check(or alias,./risedev c)Documentation
This PR adds a new option to Postgres CDC source connector, i.e.
ssl.mode.As we support ssl, we can also CREATE SOURCE on Neon databases and create multiple tables based on the shared source. See the note at the bottom of the doc https://github.com/risingwavelabs/risingwave-docs/pull/1994.
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.