Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(storage): Support key_range limitation to forward_sstable_iterator #18391

Closed
Li0k opened this issue Sep 4, 2024 · 1 comment
Closed
Assignees
Milestone

Comments

@Li0k
Copy link
Contributor

Li0k commented Sep 4, 2024

After #17898, the key_range of the sstable may be changed and no longer represent the whole object.

As a result, the current default iterator's logic for reading sstable may cross the key_range of sst to read the wrong data. We should provide SstableIterator with the ability to expose the correct data to the public based on the key_range of sstable_info, similar to SstableStreamIterator. (#18031)

@github-actions github-actions bot added this to the release-2.1 milestone Sep 4, 2024
@fuyufjh fuyufjh modified the milestones: release-2.1, release-2.2 Oct 17, 2024
@Li0k
Copy link
Contributor Author

Li0k commented Dec 7, 2024

fixd by #19582, It's not perfect, but it's simple enough. Open this issue when need it.

@Li0k Li0k closed this as completed Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants