Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics for each MV/Sink's latency #18114

Closed
fuyufjh opened this issue Aug 20, 2024 · 1 comment · Fixed by #19639
Closed

feat: metrics for each MV/Sink's latency #18114

fuyufjh opened this issue Aug 20, 2024 · 1 comment · Fixed by #19639
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Aug 20, 2024

Is your feature request related to a problem? Please describe.

Now we only have a global barrier latency.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@github-actions github-actions bot added this to the release-2.1 milestone Aug 20, 2024
@lmatz
Copy link
Contributor

lmatz commented Sep 26, 2024

Right now the barrier latency is calculated at https://github.com/risingwavelabs/risingwave/blob/main/src/meta/src/barrier/creating_job/barrier_control.rs#L288
when all the barriers are collected from worker nodes

We can calculate the latency for each MV/Sink at each CN instead of at meta node. We then take the maximum of them on Grafana dashboard via PromQL.
Since the barrier interval is large enough, e.g. 1s by default, even if there is some clock drift among different CNs, it should be ok.

cc: @lin0303-siyuan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants