You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// The subject that the referenced schema belongs to
pubsubject:String,
/// The version of the referenced schema
pubversion:i32,
}
The name field is currently unused in our code base. It is dropped and assumed to always equal to the subject field by subsequent handling logic. This assumption does not hold when the producer registers with ReferenceSubjectNameStrategy=QualifiedReferenceSubjectNameStrategy rather than ReferenceSubjectNameStrategy= DefaultReferenceSubjectNameStrategy, or the human user makes up names arbitrarily not following the default.
For example, if the main protobuf file references mypackage/myfile.proto, its subject may be mypackage/myfile.proto (default) or mypackage.myfile (qualified) for the purpose of fetching from schema registry, but its name is always mypackage/myfile.proto for the purpose of compiling with protoc.
To fix, the following Vec<Subject> shall be replaced with a container with [(String, Subject)] (Vec/HashMap/BTreeMap/...).
risingwave/src/connector/src/schema/schema_registry/util.rs
Lines 146 to 156 in 33a9302
The
name
field is currently unused in our code base. It is dropped and assumed to always equal to thesubject
field by subsequent handling logic. This assumption does not hold when the producer registers withReferenceSubjectNameStrategy=QualifiedReferenceSubjectNameStrategy
rather thanReferenceSubjectNameStrategy= DefaultReferenceSubjectNameStrategy
, or the human user makes up names arbitrarily not following the default.For example, if the main protobuf file references
mypackage/myfile.proto
, itssubject
may bemypackage/myfile.proto
(default) ormypackage.myfile
(qualified) for the purpose of fetching from schema registry, but its name is alwaysmypackage/myfile.proto
for the purpose of compiling withprotoc
.To fix, the following
Vec<Subject>
shall be replaced with a container with[(String, Subject)]
(Vec/HashMap/BTreeMap/...).risingwave/src/connector/src/schema/schema_registry/client.rs
Lines 179 to 183 in 33a9302
The text was updated successfully, but these errors were encountered: