bug:construct table could panic when there is duplicated column in the output columns

[st1page]

risingwave/src/storage/src/row_serde/mod.rs

Lines 29 to 42 in d2c547a

	pub fn find_columns_by_ids(
	table_columns: &[ColumnDesc],
	column_ids: &[ColumnId],
	) -> (Vec<ColumnDesc>, Vec<usize>) {
	let mut table_columns = table_columns
	.iter()
	.enumerate()
	.map(|(index, c)| (c.column_id, (c.clone(), index)))
	.collect::<HashMap<_, _>>();
	column_ids
	.iter()
	.map(|id| table_columns.remove(id).unwrap())
	.unzip()
	}

When there are multiple duplicated ids in the column_ids, the unwrap could panic. In most cases, the optimizer could ensure there are no duplicated columns but in some corner case, the optimizer does not optimize it, and the CN panic. I think the execution should handle this case, whether the optimizer does that optimization.

[fuyufjh]

When there are multiple duplicated ids in the column_ids, the unwrap could panic

Just read the code of HashMap and I think the panic is because none of these columns have the given column_id, not caused by duplication. Let me try to reproduce it and inspect these variables.

Sorry I misunderstood. There are duplications in column_ids rather than table_columns