Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql-backend): revert stream_node column to json type in table fragment #15051

Closed
Tracked by #12449
yezizp2012 opened this issue Feb 7, 2024 · 0 comments · Fixed by #16090
Closed
Tracked by #12449

feat(sql-backend): revert stream_node column to json type in table fragment #15051

yezizp2012 opened this issue Feb 7, 2024 · 0 comments · Fixed by #16090
Assignees
Milestone

Comments

@yezizp2012
Copy link
Member

Is your feature request related to a problem? Please describe.

Changed in #15040 . As mentioned as follows, changing it to binary type is to avoid stack overflow when deserializing it in sea-orm. Tried manually by calling serdo json encode/decode functions that was used by sea-orm, but didn't reproduce it. For better readable and maintainable we'd better identify it and revert to json type.

/// This is a workaround to avoid stack overflow when deserializing the `StreamNode` field from sql
/// backend if we store it as Json. We'd better fix it before using it in production, because it's less
/// readable and maintainable.
#[derive(Clone, PartialEq, Eq, DeriveValueType)]
pub struct StreamNode(#[sea_orm] Vec<u8>);

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant