Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem table spill only uses the last 12 bits of epoch #14892

Closed
wcy-fdu opened this issue Jan 31, 2024 · 1 comment
Closed

mem table spill only uses the last 12 bits of epoch #14892

wcy-fdu opened this issue Jan 31, 2024 · 1 comment

Comments

@wcy-fdu
Copy link
Contributor

wcy-fdu commented Jan 31, 2024

This is a feature request by recursive cte, which tend to use the high 4 bits of the last 16 bits of epoch to iterate.

After some offline discussion, this feature will not change the semantics of the current operator reading storage, and mem table spill only uses the last 12 bits of epoch (spill offset <= 4096) can be acceptable after Global memory statistics and dynamic flush threshold for mem table is implemented. We only need to change the write logic when building SSTs, limiting the spill offset up to 4096 times when writing.

Let's start this change after global memory statistics and dynamic threshold is implemented.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@wcy-fdu wcy-fdu removed this from the release-2.0 milestone Aug 19, 2024
@wcy-fdu wcy-fdu closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants