Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): Exploiting BigQuery CDC feature #14882

Closed
docteurklein opened this issue Jan 30, 2024 · 2 comments
Closed

feat(sink): Exploiting BigQuery CDC feature #14882

docteurklein opened this issue Jan 30, 2024 · 2 comments

Comments

@docteurklein
Copy link

docteurklein commented Jan 30, 2024

Hey there :)

Just discovered that bigquery supports CDC tables in GA since Oct. 2023 (https://cloud.google.com/bigquery/docs/release-notes#October_31_2023)

I'm trying to avoid google dataflow/datastream solutions, and risingwave is a serious candidate.

I just noticed that RW's bigquery sink becomes unnecessarily conservative on refusing Op different than Insert (https://github.com/risingwavelabs/risingwave/blob/main/src/connector/src/sink/big_query.rs#L328-L332),
if we append a _CHANGE_TYPE column to a CDC-enabled BQ table.

It would lift the append-only restriction, and simplify the whole stack! (see https://cloud.google.com/bigquery/docs/change-data-capture#upsert-delete-example)

Technically, this would still be an append-only sink (i.e, we only INSERT new rows, but those rows represent upstream UPDATES or DELETES).

EDIT: this would require to change the write API from tabledata.insertAll to using the storage write API (https://gkkachi.github.io/gapi-grpc-rs/gapi_grpc/google/cloud/bigquery/storage/v1beta2/big_query_write_client/struct.BigQueryWriteClient.html#method.append_rows)

@github-actions github-actions bot added this to the release-1.7 milestone Jan 30, 2024
@xiangjinwu xiangjinwu changed the title Exploiting BigQuery CDC feature feat(sink): Exploiting BigQuery CDC feature Jan 31, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@neverchanje
Copy link
Contributor

Hi, @docteurklein Please be aware that StorageWrite API is supported now. We'll include it in the upcoming 1.9 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants