Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivateLink related attributes are denied as unknown fields #14879

Closed
StrikeW opened this issue Jan 30, 2024 · 2 comments · Fixed by #14907
Closed

PrivateLink related attributes are denied as unknown fields #14879

StrikeW opened this issue Jan 30, 2024 · 2 comments · Fixed by #14907
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@StrikeW
Copy link
Contributor

StrikeW commented Jan 30, 2024

Describe the bug

CREATE SOURCE IF NOT EXISTS live_stream_metrics (
  client_ip varchar,
  user_id varchar,
  report_timestamp timestamp,
)
WITH (
  connector='kafka',
  topic='live_stream_metrics',
  privatelink.endpoint='xxx',
  privatelink.targets='[{"port": 9092}]',
  properties.bootstrap.server='b0-kafka.demosrc.risingwave.internal:9092',
  scan.startup.mode='latest'
) ROW FORMAT JSON

privatelink.targets is denied as an unknown field.

Error message/log

"msg": "ERROR: Failed to run the query\n\nCaused by these errors (recent errors listed first):\n  1: gRPC request to meta service failed: Internal error\n  2: Unknown fields in the WITH clause: {\"privatelink.targets\": \"[{\\\"port\\\": 9092}]\"}\n (SQLSTATE XX000)"

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@StrikeW StrikeW added the type/bug Something isn't working label Jan 30, 2024
@github-actions github-actions bot added this to the release-1.7 milestone Jan 30, 2024
@xiangjinwu
Copy link
Contributor

xiangjinwu commented Jan 31, 2024

Related: #13362 (can be patched similarly as a temporary workaround)

Our current approach of rejecting unknown fields (in create_source.rs) is still WRONG - and to be honest I do not have a solution either ... Certain properties (e.g. the one in this issue) are only used in compute node but the check happens in frontend, assuming most properties shall be used/checked in frontend - which is wrong or hard to maintain. 🥲

@StrikeW
Copy link
Contributor Author

StrikeW commented Jan 31, 2024

We can try to make these private link attributes as "known" fields to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants