Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDC Source: change the default value of transactional attribute to true #14818

Closed
StrikeW opened this issue Jan 26, 2024 · 0 comments · Fixed by #14899
Closed

CDC Source: change the default value of transactional attribute to true #14818

StrikeW opened this issue Jan 26, 2024 · 0 comments · Fixed by #14899
Assignees
@StrikeW
Milestone
release-1.7

Comments

@StrikeW
Copy link
Contributor

StrikeW commented Jan 26, 2024 

          > I think the overhead is not trivial, it is better to remain the `transactional` to `false` by default. @fuyufjh

Thanks for the testing work!

I prefer to enable this by default so that we can claim the CDC connector is transactional. Otherwise, telling people "Yes-but" (Yes it supports transaction but needs to be enabled manually) sounds bad to me.

Originally posted by @fuyufjh in #14375 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StrikeW StrikeW

Labels
None yet
Projects
None yet
Milestone
release-1.7
Development

Successfully merging a pull request may close this issue.

chore: enable transactional cdc for mysql and postgres by default risingwavelabs/risingwave
1 participant
@StrikeW