Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waypoints back to reward function #12

Open
Gizmotronn opened this issue Mar 10, 2020 · 1 comment · Fixed by #15
Open

Add Waypoints back to reward function #12

Gizmotronn opened this issue Mar 10, 2020 · 1 comment · Fixed by #15
Assignees
Labels
acord published on github/acord-robotics/stellarios/issues aws documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request environment linux ubuntu linux local report/log escription of how we completed a task rl-agent robomaker

Comments

@Gizmotronn
Copy link
Contributor

@wakeuplearn: "nothing i can think of right now. unless you can do a quick search on waypoints and reinforcement learning. i’ve found a lot of things online, but there still may be something I’m missing. waypoints actually do seem to help."

We're going to add waypoints back to the reward function...probably just 2 for now

We'll merge it with #11 & #10

@Gizmotronn Gizmotronn added documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request local environment linux ubuntu linux aws robomaker acord published on github/acord-robotics/stellarios/issues report/log escription of how we completed a task rl-agent labels Mar 10, 2020
@Gizmotronn
Copy link
Contributor Author

I see that you added 2 more waypoints here: https://github.com/EXYNOS-999/AWS_JPL_OSR_DRL/commit/87ce1b2515036a17bc39ed8a246884463c5459bc#diff-007f71bedbc983e8560bc575cd52a5c4






Edwin M  2:58 AM
Yes , see if you can make more efficient . Namely , having specific coordinates for the waypoints can be considered bad if the course changes . Which they may do in the evaluation . 

Liam ARBUCKLE:slack_call:  2:59 AM
So just maybe fractions, that will be say 1/3, 2/3, etc of the distance to the checkpoint?

Edwin M  5:16 AM
yes,exactly.. that’s what I have just tried. Seems to work better.

Liam ARBUCKLE:slack_call:  9:26 AM
Okay, would you lile me to add some different sets of fractions? Could work...

Edwin M  9:26 AM
its worth a try

Liam ARBUCKLE:slack_call:  10:21 AM
So what sets have you done?

acordrobotics.slack.com

@Gizmotronn Gizmotronn linked a pull request Mar 11, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acord published on github/acord-robotics/stellarios/issues aws documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request environment linux ubuntu linux local report/log escription of how we completed a task rl-agent robomaker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants