Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/paste/modify error for xperm4 implementation (from xperm8) #202

Closed
ssecatch-w opened this issue Jan 11, 2023 · 1 comment
Closed

Copy/paste/modify error for xperm4 implementation (from xperm8) #202

ssecatch-w opened this issue Jan 11, 2023 · 1 comment

Comments

@ssecatch-w
Copy link

This code appears to be copy and modified from xperm8. The bus ripping of [i+3..i] appears to be correctly modified, but the offset calculation of 8index was not modifed to 4index.
result[i+3..i] = if 8index < sizeof(xlen)
then rs1_val[8
index+3..8*index]
else zeros()

Note that there is a bounds check issue in the specific of missing the -1 for the end as reported in this issue:
riscv/riscv-crypto#202
The bounds in the SAIL model already appears to be correct

@jrtc27
Copy link
Collaborator

jrtc27 commented Jan 11, 2023

Duplicates #171 #186

@jrtc27 jrtc27 closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants