You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I gave a quick read on the Scalar Cryptography v1.0.0-rc1 and I found very minor non-consistent writing style.
In some parts of the text some words have uppercase in the first letter for all important words, while later in a similar place it only has uppercase in the beginning of a sentence. I would just adopt all letters are lowercase except the first, acronyms etc.
Here is what I found out.
Page 7, Sections 2.4 and 2.5:
All AES instructions name are lowercase, except:
AES Decrypt KeySchedule MixColumns (RV64)
AES Key Schedule Instruction 1 (RV64)
AES Key Schedule Instruction 2 (RV64)
Pages 8, 9: "Permutation" starts with uppercase, while previous "multiply" is lowercase.
Cross-bar Permutation instructions.
NIST Algorithm suite extension.
Page 62:
Table 1, mode S in the description: "an Illegal Instruction Exception"
While in the text below it is written all in lowercase "an illegal instruction exception"
Also, table 1 in page 62 is the first table with a description, while all previous tables didn't have any description. I would remove the description, since it doesn't add much and makes it consistent with previous tables.
The text was updated successfully, but these errors were encountered:
Hello, I gave a quick read on the Scalar Cryptography v1.0.0-rc1 and I found very minor non-consistent writing style.
In some parts of the text some words have uppercase in the first letter for all important words, while later in a similar place it only has uppercase in the beginning of a sentence. I would just adopt all letters are lowercase except the first, acronyms etc.
Here is what I found out.
Page 7, Sections 2.4 and 2.5:
All AES instructions name are lowercase, except:
AES Decrypt KeySchedule MixColumns (RV64)
AES Key Schedule Instruction 1 (RV64)
AES Key Schedule Instruction 2 (RV64)
AES Key Schedule Instruction 1 (RV64)
AES Key Schedule Instruction 2 (RV64)
Pages 8, 9: "Permutation" starts with uppercase, while previous "multiply" is lowercase.
Cross-bar Permutation instructions.
NIST Algorithm suite extension.
Page 62:
Table 1, mode S in the description: "an Illegal Instruction Exception"
While in the text below it is written all in lowercase "an illegal instruction exception"
Also, table 1 in page 62 is the first table with a description, while all previous tables didn't have any description. I would remove the description, since it doesn't add much and makes it consistent with previous tables.
The text was updated successfully, but these errors were encountered: