Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerojump taints the jump list #11

Open
m-pilia opened this issue Nov 6, 2019 · 1 comment
Open

Aerojump taints the jump list #11

m-pilia opened this issue Nov 6, 2019 · 1 comment

Comments

@m-pilia
Copy link

m-pilia commented Nov 6, 2019

Hi! Thanks for sharing this plugin, I love the concept and it looks really promising! However, I think there is a problem with some (probably unintentional) side effects.

Using the plugin adds spurious entries to the jump list. The effect is evident when launching a search and then interrupting it without jumping nor inserting any character. Ideally, the jump list should be unaltered, but it is not. The problem is the usage inside the plugin of commands that have the unwanted side effect of adding an entry to the jump list.

Moreover, the call to normal! H in the function Aerojump() can cause an annoying scroll of the buffer when starting a search (the effect is prominent e.g. if the user has scrolloff set to a high value, or for people that keep the cursor in the middle of the screen).

@ripxorip
Copy link
Owner

ripxorip commented Nov 7, 2019

Hi, thanks for your input. If I remember correctly, I made some effort to not clutter the jumpstack, but perhaps that is only the case when you select a match and not abort the search prematurely? I might be able to add an option for folks who like to keep the cursor in the middle of the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants