Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto scroll to current side nav item + show all breadcrumbs #161

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Auto scroll to current side nav item + show all breadcrumbs #161

merged 5 commits into from
Aug 28, 2024

Conversation

colegoldsmith
Copy link
Collaborator

No description provided.

@mlr
Copy link
Contributor

mlr commented Aug 27, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.

@mlr
Copy link
Contributor

mlr commented Aug 27, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Aug 27, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

1 similar comment
@plpesvc-ds
Copy link

plpesvc-ds commented Aug 27, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@colegoldsmith colegoldsmith mentioned this pull request Aug 27, 2024
Open
@colegoldsmith colegoldsmith linked an issue Aug 27, 2024 that may be closed by this pull request
Breadcrumb not honoring navigation hierarchy #158
Open
@mlr
Copy link
Contributor

mlr commented Aug 27, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Aug 27, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Aug 27, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Aug 27, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Aug 27, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Aug 27, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@eric-schneider eric-schneider linked an issue Aug 28, 2024 that may be closed by this pull request
Left nav doesn't auto-scroll when the number of nav entries overflows the viewable nav area #155
Closed
eric-schneider
eric-schneider approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@eric-schneider eric-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with a local bundle and confirmed that the breadcrumbs and nav auto-scrolling are both behaving as expected 🎉

@colegoldsmith colegoldsmith merged commit 312b590 into main Aug 28, 2024
2 checks passed
@colegoldsmith colegoldsmith deleted the side-nav-item-autoscroll branch August 28, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-schneider eric-schneider eric-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@colegoldsmith @mlr @plpesvc-ds @eric-schneider