Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React to changing attributes #2

Open
rinart73 opened this issue May 19, 2023 · 0 comments
Open

React to changing attributes #2

rinart73 opened this issue May 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@rinart73
Copy link
Owner

rinart73 commented May 19, 2023 •
edited
Loading

paulirish#23
@rinart73 rinart73 changed the title React to changing attributes - https://github.com/paulirish/lite-youtube-embed/issues/23 React to changing attributes May 19, 2023
@rinart73 rinart73 added the enhancement New feature or request label May 19, 2023
rinart73 added a commit that referenced this issue May 20, 2023
@rinart73
Add partial support for changing attributes
bf2bfc0 
Dynamically changing poster when related attributes are changed is currently not supported.

- Fix incorrect ESLint configuration.
- Fix missing `videoId` attribute leading to a broken YouTube poster. Currently no poster will be created. #2
- Add partial support for changing the following attributes: `videoid`, `playlistid`, `playlabel`, `showtitle`, `params`.
- Change default play button text priority. It no longer overwrites the `playlabel` attribute.
- Update examples.
rinart73 added a commit that referenced this issue May 20, 2023
@rinart73
Add partial support for changing attributes
6abbf27 
Dynamically changing poster when related attributes are changed is currently not supported.

- Fix incorrect ESLint configuration.
- Fix missing `videoId` attribute leading to a broken YouTube poster. Currently no poster will be created. #2
- Add partial support for changing the following attributes: `videoid`, `playlistid`, `playlabel`, `showtitle`, `params`.
- Change default play button text priority. It no longer overwrites the `playlabel` attribute.
- Update examples.

Fix global default values not being used

- Fix global config default values 'playLabel', 'showTitle', 'params' not being used when their related attributes aren't set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rinart73