From 9242858519d7100b21d4d50f282b312a6a10280e Mon Sep 17 00:00:00 2001 From: Dhiraj Kumar Date: Fri, 3 Jan 2025 22:00:27 +0530 Subject: [PATCH] Cleanup --- .../features/canvas/components/charts/util.ts | 2 -- .../src/features/canvas/components/config.ts | 0 .../features/canvas/state-managers/types.ts | 18 ------------------ 3 files changed, 20 deletions(-) delete mode 100644 web-common/src/features/canvas/components/config.ts delete mode 100644 web-common/src/features/canvas/state-managers/types.ts diff --git a/web-common/src/features/canvas/components/charts/util.ts b/web-common/src/features/canvas/components/charts/util.ts index 81921a36e99..1e8f5e69595 100644 --- a/web-common/src/features/canvas/components/charts/util.ts +++ b/web-common/src/features/canvas/components/charts/util.ts @@ -21,8 +21,6 @@ export function generateSpec( return generateVLStackedBarChartSpec(chartConfig, data); case "line_chart": return generateVLLineChartSpec(chartConfig, data); - default: - return generateVLBarChartSpec(chartConfig, data); } } diff --git a/web-common/src/features/canvas/components/config.ts b/web-common/src/features/canvas/components/config.ts deleted file mode 100644 index e69de29bb2d..00000000000 diff --git a/web-common/src/features/canvas/state-managers/types.ts b/web-common/src/features/canvas/state-managers/types.ts deleted file mode 100644 index a10afc7cd9a..00000000000 --- a/web-common/src/features/canvas/state-managers/types.ts +++ /dev/null @@ -1,18 +0,0 @@ -import type { CanvasEntity } from "@rilldata/web-common/features/canvas/stores/canvas-entity"; - -/** - * A CanvasMutatorCallback is a function that mutates - * a CanvasEntity, i.e., the data single Canvas. - * This will often be a closure over other parameters - * that are relevant to the mutation. - */ -export type CanvasMutatorCallback = (canvasEntity: CanvasEntity) => void; - -/** - * CanvasCallbackExecutor is a function that takes a - * CanvasMutatorCallback and executes it. The - * CanvasCallbackExecutor is a closure containing a reference - * to the live Canvas, and therefore calling this function - * on a CanvasMutatorCallback will actually update the Canvas. - */ -export type CanvasCallbackExecutor = (callback: CanvasMutatorCallback) => void;