-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use feature flag to enable wasm builds #159
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Daniel Thompson-Yvetot <[email protected]>
Signed-off-by: Daniel Thompson-Yvetot <[email protected]>
I didn't mention that I tested this both with build and test (on macos). |
Signed-off-by: Daniel Thompson-Yvetot <[email protected]>
This can get merged, its a non-breaking change. |
@nothingismagick does this need to be made more general? https://github.com/nothingismagick/riker/blob/master/src/system.rs#L269 |
@lukewestby I'm working on an agnostic executor library to enable riker to use different executors, including WASM. That would be a first step into making riker wasm compatible. But it's not only the threadpool, it's also integrating with timers (also supported by the new library), testing with wasm-pack, using channels that work in WASM (it can be tricky sometimes) and I'm sure many more things. |
Understood. Thank you! |
Just to let you know, I'm not sure anymore that riker can ever support WASM without major changes. And even if major incompatible changes were introduced to fix that, there are still many more things to fix. Sure, it could be done, but it's probably better to create a lighter actor library from scratch, with WASM and agnostic executors support baked in from the beginning. And leave riker for the server use case that was designed for. |
WASM isn't just for the browser and riker isn't just for a server... Just saying |
Sure. Let's just say current riker design is not really WASM friendly. Anyone can apply it to their own use case ;-) |
Closes #151.
This just adds a feature flag (and relevant uuid feature) that allows devs to conditionally compile riker for wasm runtimes.