Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Auto-add icons on the synced bookmarks #9

Open
Nickfrm opened this issue Jun 21, 2021 · 4 comments
Open

Auto-add icons on the synced bookmarks #9

Nickfrm opened this issue Jun 21, 2021 · 4 comments

Comments

@Nickfrm
Copy link

Nickfrm commented Jun 21, 2021

All bookmarks after first load the extension have an unassociated look. It would be great if the synced bookmarks have icons by default.

image

@danilkinkin
Copy link
Member

Hello, sorry for late answer. Now i'm migrate to new extensions API (MV3).

I still can't generate icons in the background for a large number of bookmarks at once. As soon as I figure out how to implement this, I will immediately do it. The problem is that the search and generation of one icon can take up to 30 seconds. When there are a lot of bookmarks, it becomes critical.

@Nickfrm
Copy link
Author

Nickfrm commented Aug 2, 2021

Ok, what about making this synchronization manual as a temporary workaround?

@Nickfrm
Copy link
Author

Nickfrm commented Aug 2, 2021

As an idea for brainstorm:

  1. Lazy-load (if you don't want to load network) of icons. I mean creating a cron job for loading.
  2. Create a cache layer between searching icons on the web. In that case, if you already have an icon for the website it won't search it on the web.

@danilkinkin
Copy link
Member

Cache already used in production. All icons created through server.

Probably it is worth doing this in the background and notifying the user that it will take time.
The problem is even more that I can not determine the ideal icon, the algorithm needs to be upgrade. If this process run in the background, then it should take place without the participation of the user, which means I should be very good at choosing icons

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants