Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: investigate memory leak #5

Open
richthegeek opened this issue Jan 9, 2019 · 2 comments
Open

Regression: investigate memory leak #5

richthegeek opened this issue Jan 9, 2019 · 2 comments

Comments

@richthegeek
Copy link
Owner

Memory leak observed in dependant applications from no earlier than 3.1

Figure out which version to blame and investigate changes in that version.
@richthegeek
Copy link
Owner Author

Regression pinned to 3.3.0 (bd0cfcd): performance before is signifantly improved.

@richthegeek
Copy link
Owner Author

Isolated to line

beatrix/src/job.js

Line 159 in bd0cfcd

this.log.trace = this.log.trace.bind(this.log, {messageId: message.properties.messageId})

The bind here is recursive, so each job builds on the last.

Stripping out tracing, replacing it with debug, is a viable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richthegeek