Use memcpy for unaligned reads to appease UBSan #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
memcpy
to perform unaligned reads, instead ofreinterpret_cast
. In tests on godbolt, this generated a single unaligned read on x86 and x86_64 platforms even under-O0
. Other platforms generate byte reads and then stitch them together with shifting. Writing it this way removes the need for the build to force byte reads when UBSan is enabled. However, unfortunatelyFPNG_USE_UNALIGNED_LOADS
is still needed for performance inREAD_RGB_PIXEL
, because most compilers cannot remove the vestigial fourth byte read on platforms that require aligned reads.