Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The salt should not be static. #27

Open
cryptochecktool opened this issue Nov 16, 2024 · 3 comments
Open

The salt should not be static. #27

cryptochecktool opened this issue Nov 16, 2024 · 3 comments

Comments

@cryptochecktool
Copy link

The salt should not be set as a static variable, as this will lead to reduced security. See https://github.com/richardpenman/browsercookie/blob/9d5e80788504c8b950bda31e377585252d7abc31/browsercookie/init.py#L106 for the reference.

@richardpenman
Copy link
Owner

That link 404's. Could you clarify what you mean?

@cryptochecktool
Copy link
Author

init.py#L106

class ChromeBased(BrowserCookieLoader):
def get_cookies(self):
salt = b'saltysalt'
length = 16
keys = []

the salt should not be static,need random for anyone.

@richardpenman
Copy link
Owner

This salt is for decrypting cookies and is the hardcoded value used by chrome:
https://gist.github.com/creachadair/937179894a24571ce9860e2475a2d2ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants