Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for rails 6 and 7 #73

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

HassanAkbar
Copy link

Upgraded to support Rails 6 and Rails 7

resolves #72

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Rails found in .rubocop.yml, unrecognized cop Rails/A...
Error: unrecognized cop Rails found in .rubocop.yml, unrecognized cop Rails/ApplicationRecord found in .rubocop.yml

- support for ruby version < 2.6 removed
- support for rails version < 5.2 removed
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Rails found in .rubocop.yml, unrecognized cop Rails/A...
Error: unrecognized cop Rails found in .rubocop.yml, unrecognized cop Rails/ApplicationRecord found in .rubocop.yml

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Performance/CaseWhenSplat found in .rubocop.yml, unre...
Error: unrecognized cop Performance/CaseWhenSplat found in .rubocop.yml, unrecognized cop Performance/Count found in .rubocop.yml, unrecognized cop Performance/Detect found in .rubocop.yml, unrecognized cop Performance/FlatMap found in .rubocop.yml, unrecognized cop Performance/ReverseEach found in .rubocop.yml, unrecognized cop Performance/Size found in .rubocop.yml, unrecognized cop Performance/StringReplacement found in .rubocop.yml

@HassanAkbar
Copy link
Author

@ronaldtse the jruby test cases for postgresql are failing and I think that is because of this issue in jruby itself when using UUIDs jruby/activerecord-jdbc-adapter#1086

I will look into it further but if this is the cause of the issue then what do you suggest we do until the issue is fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to support Rails 6 and Rails 7
1 participant