Rework presign function to allow signature of clients with dedicated endpoint #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemunaire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It is not possible to use the presign function with custom endpoint (non-AWS), especially with endpoint that includes bucket name in path instead of virtual host: the hostname is systematically tweaked to add the unwanted bucket name.
See knadh/listmonk#1782
Here is a patch to allow this library to presign URL for Minio and other non-AWS S3 providers. Perhaps it lacks a force_path_style attribute something to mock the aws library behavior in this case.
As the Endpoint (in fact hostname) is redundant in presign request, I remove it in favor of the endpoint given in the s3 client.
Tested with Minio and Oracle Cloud Infrastructure, should be tested with AWS S3 (I don't have an account).