Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should graphql be added as a dependency? #68

Open
matheusdc opened this issue Feb 18, 2021 · 1 comment
Open

Should graphql be added as a dependency? #68

matheusdc opened this issue Feb 18, 2021 · 1 comment
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@matheusdc
Copy link

When installed in a project that doesn't have graphql it throws an error:

Error: Cannot find module 'graphql'

I wonder where would be the proper place for this dependency to be. Should graphql be installed as a devDependency in my project? Even if it is not planning to use any of its features? Or this lib should be a dependency on the-fake-backend?

Would like to hear other opinions on that.

@rhberro rhberro added bug Something isn't working question Further information is requested labels Mar 4, 2021
@adrifmonte
Copy link

Good point, I faced the same issue in my project.
Not exactly sure, maybe if it was an optionalDependency it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants