5 Parental Bond tests #3606
5 Parental Bond tests #3606
Conversation
| GIVEN { | ||
| ASSUME(gBattleMoves[MOVE_TRIPLE_KICK].split != SPLIT_STATUS); | ||
| ASSUME(gBattleMoves[MOVE_TRIPLE_KICK].strikeCount == 3); | ||
| ASSUME(gBattleMoves[MOVE_TRIPLE_KICK].effect == EFFECT_TRIPLE_KICK); |
There was a problem hiding this comment.
Is the assume for the effect needed here it shouldn't effect the test in any way?
| GIVEN { | ||
| ASSUME(gBattleMoves[MOVE_EARTHQUAKE].split != SPLIT_STATUS); | ||
| ASSUME(gBattleMoves[MOVE_EARTHQUAKE].strikeCount < 2); | ||
| ASSUME(gBattleMoves[MOVE_EARTHQUAKE].effect == EFFECT_EARTHQUAKE); |
There was a problem hiding this comment.
Again not sure if assuming Earthquake effect matters here but I think the assume for MOVE_TARGET_FOES_AND_ALLY should be added.
| u16 move; | ||
| PARAMETRIZE { move = MOVE_EARTHQUAKE; } | ||
| PARAMETRIZE { move = MOVE_ROCK_SLIDE; } | ||
| GIVEN { |
There was a problem hiding this comment.
Assume for MOVE_TARGET_FOES_AND_ALLY
| GIVEN { | ||
| ASSUME(gBattleMoves[MOVE_EARTHQUAKE].split != SPLIT_STATUS); | ||
| ASSUME(gBattleMoves[MOVE_EARTHQUAKE].strikeCount < 2); | ||
| ASSUME(gBattleMoves[MOVE_EARTHQUAKE].effect == EFFECT_EARTHQUAKE); |
There was a problem hiding this comment.
Again maybe remove effect EQ and add MOVE_TARGET_FOES_AND_ALLY
That's why Rock Slide is there :) |
Oh sorry, mb. Though I would also remove the flinch effect assume. |
The flinch assume is necessary in this case, since it does in fact make the two opponents flinch (and the messages depend on that). I could alternatively move the flinch check there and make it check for regular Celebrate usage if the effect is not set to flinching, though |
In this case I would check the HP bar a second time but negated instead of the messages and celebrate. |
|
What's the status of this? 👀 |
|
superseded by #3973 |
Adds five of the many Parental Bond tests that still need to be written
Issue(s) that this PR fixes
Partially fixes #3430
Discord contact info
bassoonian