forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] BoxPokemon Refactor ™️ #2372
Closed
AsparagusEduardo
wants to merge
28
commits into
rh-hideout:upcoming
from
AsparagusEduardo:RHH/pr/breaking/BoxMon
Closed
[WIP] BoxPokemon Refactor ™️ #2372
AsparagusEduardo
wants to merge
28
commits into
rh-hideout:upcoming
from
AsparagusEduardo:RHH/pr/breaking/BoxMon
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit: ea9b165 Original comment: Reduces BoxMon struct size to 64 bytes; encryption removed, data reordered/compressed and several functions modified. Some functions whose purpose I don't undestand I left in despite them no longer doing anything (scrcmd). Breaks compatibility with other Gen III games unless a converted is made (doable, but not something I'm interested in). # Conflicts: # .gitattributes # include/pokemon.h # include/pokemon_storage_system.h # src/battle_util.c # src/egg_hatch.c # src/evolution_scene.c # src/party_menu.c # src/pokemon.c # src/pokemon_storage_system.c # src/scrcmd.c # src/trade.c
…press # Conflicts: # src/evolution_scene.c
AsparagusEduardo
added
category: pokemon
Pertains to Pokémon data and functionality
type: BREAKING
Not to be merged lightly, needs to be reviewed
labels
Oct 3, 2022
Removed Level 255 support |
…ing/BoxMon # Conflicts: # src/pokemon_summary_screen.c # src/trade.c
# Conflicts: # include/global.h # include/pokemon.h # src/battle_anim_mons.c # src/battle_gfx_sfx_util.c # src/contest.c # src/evolution_scene.c # src/pokedex.c # src/pokemon.c # src/trainer_pokemon_sprites.c
AsparagusEduardo
changed the title
[BREAKING][WIP] Pokemon and BoxPokemon refactor
[For 2.0][WIP] Pokemon and BoxPokemon refactor
Feb 25, 2023
AsparagusEduardo
changed the title
[For 2.0][WIP] Pokemon and BoxPokemon refactor
[For 2.0][WIP] BoxPokemon Refactor ™️
Feb 25, 2023
# Conflicts: # include/constants/global.h # include/pokemon.h # src/battle_controller_link_opponent.c # src/battle_controller_link_partner.c # src/battle_controller_opponent.c # src/battle_controller_player.c # src/battle_controller_player_partner.c # src/battle_controller_recorded_opponent.c # src/battle_controller_recorded_player.c # src/battle_controller_wally.c # src/battle_gfx_sfx_util.c # src/battle_tower.c # src/battle_util.c # src/egg_hatch.c # src/menu_specialized.c # src/party_menu.c # src/pokemon.c # src/pokenav_conditions.c # src/scrcmd.c # src/trade.c # src/trainer_pokemon_sprites.c
# Conflicts: # src/battle_gfx_sfx_util.c # src/battle_util.c
AsparagusEduardo
changed the title
[For 2.0][WIP] BoxPokemon Refactor ™️
[WIP] BoxPokemon Refactor ™️
Oct 20, 2023
Replaced by #3438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: pokemon
Pertains to Pokémon data and functionality
type: BREAKING
Not to be merged lightly, needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Pokemon and BoxPokemon structure to future proof and allow for new features.
It optimizes the struct to have more fields in the same amount of space (80 bytes for BoxPokemon and 100 bytes for Pokemon)
Support for:
isShadow
flag for future Shadow Pokémon implementation.Todo:
Will not do:
Discord contact info
AsparagusEduardo#6051