EFFECT_MORNING_SUN and EFFECT_MOONLIGHT are redundant

[BuffelSaft]

This seems to be junk leftover from gen 2, where these moves were actually different (they each healed different amounts based on the time of day). From gen 3 onwards, they're identical to EFFECT_SYNTHESIS, so they could all use the same move effect.

This would simplify checks like this:

if (HasMoveEffect(battlerDef, EFFECT_MORNING_SUN) 
|| HasMoveEffect(battlerDef, EFFECT_SYNTHESIS) 
|| HasMoveEffect(battlerDef, EFFECT_MOONLIGHT))

into if (HasMoveEffect(battlerDef, EFFECT_SYNTHESIS)

[AsparagusEduardo]

Comparing the Bulbapedia page, Moonlight doesn't state what happens in Strong Winds, compared to the other two moves.

[AsparagusEduardo]

Confirmed that in USUM all three moves have the exact same effect.

[DizzyEggg]

We could always keep the effects and add a config for the GEN2 behaviour.

[AsparagusEduardo]

We could always keep the effects and add a config for the GEN2 behaviour.

I remember there were discussions about emulating Gen 1/2's battle quirks via config once we caught up to the latest Gen and had nothing else to do, but didn't go too far.

At one point I tested the possibility of adding mid-gen configs, including Gen 1/2 ones, but ended up being too convoluted. Maybe we could start looking into it again 👀

[DizzyEggg]

We could always keep the effects and add a config for the GEN2 behaviour.

I remember there were discussions about emulating Gen 1/2's battle quirks via config once we caught up to the latest Gen and had nothing else to do, but didn't go too far.

At one point I tested the possibility of adding mid-gen configs, including Gen 1/2 ones, but ended up being too convoluted. Maybe we could start looking into it again 👀

Yeah, I noticed you even started with one PR for Shuckle gen2 behavior. I think having them as available, but set to FALSE by default, is a good option.