Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up move animation related code and assets #1836

Open
LOuroboros opened this issue Oct 30, 2021 · 1 comment
Open

Clean up move animation related code and assets #1836

LOuroboros opened this issue Oct 30, 2021 · 1 comment
Labels
category: battle-mechanic Pertains to battle mechanics category: move animation Pertains to move animations type: reminder

Comments

@LOuroboros
Copy link
Collaborator

So, earlier today, as I was testing out the changes in #1835, I noticed that there's a handful of duplicated assets that go unused.
For example, Dark Void has assets in both, graphics/battle_anims/backgrounds and graphics/battle_anims/backgrounds/new, and the latter set goes unused.
Dark Void isn't the only one. Other similar cases are Trick Room, Rock Wrecker and Spacial Rend.

Ideally, we shouldn't keep copies pointlessly, because there's just no reason to.
@LOuroboros LOuroboros added category: battle-mechanic Pertains to battle mechanics gen: 4 category: move animation Pertains to move animations type: reminder and removed gen: 5 labels Oct 30, 2021
@LOuroboros
Copy link
Collaborator Author

Other tasks that could or should be handled before closing this Issue ticket:
firefox_1702

@LOuroboros LOuroboros changed the title Clean up src/graphics.c and delete unused BG related files Clean up move animation related code and assets Oct 31, 2021
AsparagusEduardo pushed a commit that referenced this issue Jan 20, 2023
@GriffinRichards
Merge pull request #1836 from GriffinRichards/fix-clone
c663154 
Add fix for Battle Tower cloning bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: battle-mechanic Pertains to battle mechanics category: move animation Pertains to move animations type: reminder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AsparagusEduardo @LOuroboros