Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into library + command line client #34

Open
ryancdotorg opened this issue Mar 10, 2020 · 7 comments
Open

Refactor into library + command line client #34

ryancdotorg opened this issue Mar 10, 2020 · 7 comments

Comments

@ryancdotorg
Copy link
Contributor

II want to do some automation, and I'd rather not wrap the command line client to do so.

If I refactor this client into a library which the command line client imports and uses, will you accept a pull request?

@rgerganov
Copy link
Owner

Sure, I'd be happy to accept a pull request for this. There have been also people in the past asking for this, e.g. issue #15

@ekeih
Copy link

ekeih commented Mar 14, 2020

Maybe joining forces with https://github.com/urbas/philips-air-purifier could be an option here?

@ryancdotorg I am currently looking into writing a home assistant integration based on py-air-control. I already wanted to do this a year ago in #15, but now that the allergy season in Germany is starting again, I want to give it another try.
In case you are working on the same, we should talk to each other to avoid duplicate work. :)

@ryancdotorg
Copy link
Contributor Author

I already went through and made heavy modifications to urbas/philips-air-purifier, which is working nicely, but is HTTP only. That will be easy to roll back in to this project, though. I tried to pick the best of both worlds. I will try to get that posted somewhere today.

I'm trying to get the CoAP stuff working since the AC2889/60 I bought does not support HTTP, and not having much luck.

@ekeih I would be happy to work with you on this. I'm about to go AFK for a bit, but perhaps we can talk a little later to figure out how to split this up? I'm happy to converse via Signal, Wire, Keybase, Twitter DM or IRC.

@ryancdotorg
Copy link
Contributor Author

My refactor of the other codebase is here: https://github.com/ryancdotorg/philips-air-purifier/blob/refactor/philips_air_purifier/air_purifier.py

I'd like to add some caching to it, tempted to just remove all the explicit methods.

@GeorgeSG
Copy link
Contributor

+1, is anyone working on this? I'm willing to give it a shot if nobody is doing it.

@ekeih, I want to refactor https://github.com/xMrVizzy/philips-airpurifier to use this for Home Assistant.

@rgerganov
Copy link
Owner

+1, is anyone working on this? I'm willing to give it a shot if nobody is doing it.

Sure, contributions are welcome! Now that we have the CoAP support almost ready, we can spend some time on refactoring and providing a library for other projects to integrate.

@ekeih
Copy link

ekeih commented May 26, 2020

@GeorgeSG @ryancdotorg Sorry for not responding earlier. Each spring during the allergy season I am interested in this and then when the season ends after a few weeks/months I loose interest when our purifier goes back into storage 🙈
So @GeorgeSG feel free to take a shot at it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants