Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0.0] Examples show JsonRipper and StoreService imports but they are not in the public_api file #329

Open
BenLune opened this issue Aug 25, 2021 · 1 comment

Comments

@BenLune
Copy link

BenLune commented Aug 25, 2021

Hi,
Congratulations for this lib, it seems quite interesting and powerful.
I'm trying to use it and it works.
I would like to test the cache capabilities and when I look at the doc, it isn't very clear. Example shows the use of JsonRipper and StoreService, but they're not in the public_api.

Also, in the doc, you should write the new way to init JsonapiBootstrap this way :

JsonapiBootstrap.bootstrap({
      user_config: {url: 'https://my.api'}
});

I discovered the bootstrap static function looking at the code.

Thank you for the lib and for your help !

@BenLune
Copy link
Author

BenLune commented Aug 25, 2021

Here, in your example :

import { NgxJsonapiModule } from 'ngx-jsonapi';
import { StoreService } from 'ngx-jsonapi/sources/store.service';
import { JsonRipper } from 'ngx-jsonapi/services/json-ripper';

@NgModule()
export class AppModule {
    public constructor() {
        JsonapiBootstrap({
            user_config: { url: '//jsonapiplayground.reyesoft.com/v2/' },
            jsonapiStore: new StoreFakeService(),
            jsonRipper: new JsonRipperFake()
        });
    }
}

You import import { StoreService } from 'ngx-jsonapi/sources/store.service';
import { JsonRipper } from 'ngx-jsonapi/services/json-ripper';
Those classes are not exported in the public_api file, so we can't use them or I missed something.

but you use StoreFakeService and JsonRipperFake instead, this example doesn't seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant