Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement handle_info/2 #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francois-codes
Copy link
Contributor

When running the project again, I noticed some errors I didn't see before in the output:

image

This messages correspond to the messages sent by the nodejs for warnings and debugging info.

This PR fixes the problem by implementing the handle_info/2 method, as advised in the error message. In order to avoid the spam, I added a check for Mix.env() to make sure we were only showing this information in dev.

This is the equivalent of the command above with this PR:

image

FYI @Valian @grossvogel

@francois-codes
Copy link
Contributor Author

@grossvogel do you think you could have a look at this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant