engineering#245 - change push conditions to require a tag AND master branch #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samkeer1
changed the title
texastoast
approved these changes
Apr 22, 2024
|
@Samkeer1 not sure what you mean by a PR. This is the only repo, it's published via |
|
@texastoast I'm suggesting that we make a suggestion to change the copy that hex provides, because it could be more descriptive. |
|
@Samkeer1 makes sense to me, I'd say call your shot and if you think it needs to be more descriptive, make a PR. |
grossvogel
reviewed
May 31, 2024
| @@ -3,7 +3,6 @@ name: Publish | |||
| on: | |||
| push: | |||
| tags: [ 'v*.*.*' ] | |||
| branches: master | |||
There was a problem hiding this comment.
This change is in master now as of #171
| @@ -14,6 +13,7 @@ jobs: | |||
| uses: ./.github/workflows/test.yml | |||
| publish: | |||
| needs: test | |||
| if: ${{ github.ref_name == 'master' }} | |||
There was a problem hiding this comment.
I don't think this is necessary. In fact, we could decide to maintain multiple branches, for example if we went 3.0 on master but still wanted to allow bugfixes to be released to 2.X.
|
@Samkeer1 do you mind if I close this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to failed publish:
https://github.com/revelrylabs/ecto_soft_delete/actions/runs/8571557508/job/23492117202
The error indicates we're trying to re-publish an existing version after the hour window of published version update availability. Perhaps we can open a https://github.com/hexpm/hexpm PR that checks to see if attempts to publish packages are from over x amount of time after a publish, and if so, displays separate or even additional error copy (e.g "further updates to this package will require a package version update")