Side quest: Optimize ReadOnlyInvocationStatusTable#all_invoked_or_killed_invocations #2349
+991
−292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t after a kill, the invoker will send a "terminal" effect to the state machine.
Also replace the individual booleans for experimental features with enum set.
…ons, by avoiding loading the full InvocationStatus in memory.
slinkydeveloper
commented
Nov 22, 2024
Comment on lines
+354
to
+371
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| pub enum InvocationStatusDiscriminants { | ||
| Scheduled, | ||
| Inboxed, | ||
| Invoked, | ||
| Suspended, | ||
| Killed, | ||
| Completed, | ||
| } | ||
|
|
||
| /// Lite status of an invocation. | ||
| #[derive(Debug, Clone, Eq, PartialEq)] | ||
| pub struct InvocationLite { | ||
| pub status: InvocationStatusDiscriminants, | ||
| pub invocation_target: InvocationTarget, | ||
| } | ||
|
|
||
| protobuf_storage_encode_decode!(InvocationLite, crate::storage::v1::InvocationV2Lite); |
There was a problem hiding this comment.
The only reason for this type to be here is the package organization, otherwise i could have hid everything in the partition-store module (and i could have even avoided defining the Lite type in the domain.proto).
There was a problem hiding this comment.
I guess this is good reason to correct this part eventually.
tillrohrmann
approved these changes
Nov 29, 2024
Comment on lines
+354
to
+371
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| pub enum InvocationStatusDiscriminants { | ||
| Scheduled, | ||
| Inboxed, | ||
| Invoked, | ||
| Suspended, | ||
| Killed, | ||
| Completed, | ||
| } | ||
|
|
||
| /// Lite status of an invocation. | ||
| #[derive(Debug, Clone, Eq, PartialEq)] | ||
| pub struct InvocationLite { | ||
| pub status: InvocationStatusDiscriminants, | ||
| pub invocation_target: InvocationTarget, | ||
| } | ||
|
|
||
| protobuf_storage_encode_decode!(InvocationLite, crate::storage::v1::InvocationV2Lite); |
There was a problem hiding this comment.
I guess this is good reason to correct this part eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids loading the full InvocationStatus in memory, only to read invocation target and status. Depends on #2335, only the last commit is relevant to this PR