Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestRawFeminosRootToSignalProcess sets a wrong timestamp #149

Open
AlvaroEzq opened this issue Nov 26, 2024 · 1 comment · May be fixed by #150
Open

TRestRawFeminosRootToSignalProcess sets a wrong timestamp #149

AlvaroEzq opened this issue Nov 26, 2024 · 1 comment · May be fixed by #150
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AlvaroEzq
Copy link
Contributor

The timestamp of the event is not set correctly in this line:

// TODO: double check this is correct
fSignalEvent->SetTime(fInputEventTreeTimestamp / 1000, fInputEventTreeTimestamp % 1000);

This is due to the fInputEventTreeTimestamp being in milliseconds and the method TRestEvent::SetTime second parameter is nanoseconds. So the subsecond information of the timestamp is not correct. This should be solved easily by just changing that line to
fSignalEvent->SetTime(fInputEventTreeTimestamp / 1000, fInputEventTreeTimestamp % 1000 * 1.e6);

@AlvaroEzq AlvaroEzq added bug Something isn't working good first issue Good for newcomers labels Nov 26, 2024
@lobis
Copy link
Member

lobis commented Nov 26, 2024

Feel free to do the PR @AlvaroEzq if this is just a single line change (probably takes less time than actually writing the issue!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants