Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRestRawSignal should use unsigned short instead of signed short #115

Open
lobis opened this issue Aug 8, 2023 · 0 comments · May be fixed by #116
Open

TRestRawSignal should use unsigned short instead of signed short #115

lobis opened this issue Aug 8, 2023 · 0 comments · May be fixed by #116

Comments

@lobis
Copy link
Member

lobis commented Aug 8, 2023

This has been discussed a few times already: signal data should be stored as unsigned integer instead of a signed integer as it better represents ADC units.

The change is easy to do but it might break many things so it should be done carefully.
@lobis lobis linked a pull request Aug 8, 2023 that will close this issue
Replace Short_t by UShort_t in raw signal #116
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Short_t by UShort_t in raw signal rest-for-physics/rawlib
1 participant
@lobis