Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for old Garfield versions #40

Open
lobis opened this issue Mar 24, 2022 · 2 comments · May be fixed by #41
Open

Drop support for old Garfield versions #40

lobis opened this issue Mar 24, 2022 · 2 comments · May be fixed by #41

Comments

@lobis
Copy link
Member

lobis commented Mar 24, 2022 •
edited
Loading

Recently we started supporting new versions of Garfield, which come with breaking changes. I made a few changes to the CMake and the code via preprocessor directives to support both versions, but recently @DavidDiezIb had some problems with the old version which means there is probably some unnoticed issue. I don't think its worth it to keep supporting these old versions, so I vote to just be compatible with the most recent version or a fairly recent one. (I would say latest tag, but currently this latest tag has a bug...).

rest-for-physics/framework@e58bdf4 removes the cmake file used to find the old Garfield and I will make the appropriate changes in this PR.

What do you think? @jgalan @nkx111 @juanangp

Related PR: #41 (review)
@lobis lobis linked a pull request Mar 24, 2022 that will close this issue
Open
@lobis lobis linked a pull request Mar 24, 2022 that will close this issue
Drop support for old Garfield versions #41
Open
@nkx111
Copy link
Member

nkx111 commented Mar 25, 2022

I never tried the new version of Garfield. Will it make some difference to the drift speed simulated?

@lobis
Copy link
Member Author

lobis commented Mar 26, 2022 •
edited
Loading

I never tried the new version of Garfield. Will it make some difference to the drift speed simulated?

I would say no, it would be interesting if someone can test this. We don't need to use the latest Garfield version, just a version that is not that old and has better CMake support. Our "official" version is like 5 years old or so if I remember correctly.

Anyway its really easy to update to a more recent Garfield version, there are not that many changes to the user API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop support for old Garfield versions rest-for-physics/detectorlib
2 participants
@nkx111 @lobis