Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract away file path creation in DefaultStoreConfiguration #97

Open
coderabbitai bot opened this issue Sep 11, 2024 · 0 comments
Open

Abstract away file path creation in DefaultStoreConfiguration #97

coderabbitai bot opened this issue Sep 11, 2024 · 0 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

In the file debugger/server/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/server/arch/configuration/DefaultStoreConfiguration.kt, there is a TODO comment to abstract away the file path creation logic:

// TODO: Abstract away
path = File("states").apply { mkdirs() }.resolve(".json").absolutePath,

This abstraction will improve modularity and reusability of the code.

Related PR: //pull/96
Comment: //pull/96#discussion_r1755641491

Requested by: @Nek-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant