Incoming number sent to JS listener

[beradrian]

It would be useful if instead of the state as a string on the JS listener you'll receive an object with two properties: state and incomingNumber.

[leonzinger]

+1
And caller name if in phone book :)

[renanoliveira]

Hi @beradrian and @leonzinger

Today I have two pull requests about this.
I need study this solution because one used a json object ({"RINGING": "NUMBER}) for all states and other concatenate number on ringing state (RINGING + "NUMBER").

Do you have any preference?

[guillaume-fr]

It's better to have a JSONObject with the following definition : { state:"RINGING", number:"NUMBER}

It's explicit and avoids breaking changes if you want to add caller name or any other info later.

[leonzinger]

I prefer JSON as well.

Thank you!

On Mon, Oct 26, 2015 at 11:50 AM guillaume-fr [email protected]
wrote:

It's better to have a JSONObject with the following definition : {
state:"RINGING", number:"NUMBER}

It's explicit and avoids breaking changes if you want to add caller name
or any other info later.

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

[beradrian]

I agree with @guillaume-fr { state:"RINGING", number:"NUMBER}. JSON is much better.

[RishabhKothaari]

Hi @renanoliveira thanks for the plugin , can you pull this fix #7 .