Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate examples to latest remix v2 #485

Open
24 of 79 tasks
machour opened this issue May 28, 2024 · 4 comments
Open
24 of 79 tasks

Migrate examples to latest remix v2 #485

machour opened this issue May 28, 2024 · 4 comments

Comments

@machour
Copy link
Collaborator

machour commented May 28, 2024

Keeping track of progress here:

  • __template
  • _official-blog-tutorial (archived, won't be touched)
  • _official-contacts-tutorial
  • _official-jokes (archived, won't be touched)
  • _official-realtime-app
  • bullmq-task-queue
  • catch-boundary (=> error-boundary)
  • chakra-ui
  • client-only-components
  • client-side-validation
  • collected-notes
  • combobox-resource-route
  • dark-mode
  • dataloader
  • docker-with-yarn-pnp
  • emotion
  • file-and-cloudinary-upload
  • file-and-s3-upload
  • firebase
  • form-to-notion-db
  • framer-motion
  • framer-route-animation
  • gdpr-cookie-consent
  • google-analytics
  • graphql-api
  • image-resize
  • infinite-scrolling
  • io-ts-formdata-decoding
  • ioredis
  • leaflet
  • mantine
  • msw
  • multiple-forms
  • multiple-params
  • newsletter-signup
  • nprogress
  • on-demand-hydration
  • outlet-form-rerender
  • pathless-routes
  • picocss
  • playwright
  • pm-app
  • quirrel
  • react-quill
  • react-spring
  • redis-upstash-session
  • remix-auth-auth0
  • remix-auth-form
  • remix-auth-github
  • remix-auth-supabase
  • remix-auth-supabase-github
  • route-modal
  • routes-gen
  • rust
  • sanity
  • sass
  • search-input
  • session-flash
  • sharing-loader-data
  • socket.io
  • sse-chat
  • sse-counter
  • stitches
  • strapi
  • stripe-integration
  • styled-components
  • styletron
  • supabase-subscription
  • tailwindcss
  • theme-ui
  • tiptap-collab-editing
  • toast-message
  • turborepo-vercel
  • twind
  • unocss
  • vanilla-extract
  • xata
  • yarn-pnp
  • zerops-example
@machour
Copy link
Collaborator Author

machour commented May 28, 2024

Also updated UnoCSS's remix example: unocss/unocss#3850

@imaitland
Copy link

@machour Curious - Why is jokes archived and "won't be touched". The prod build currently fails with:

➜  _official-jokes git:(main) npx prisma migrate deploy
Need to install the following packages:
[email protected]
Ok to proceed? (y) y

Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": SQLite database "dev.db" at "file:./dev.db"

1 migration found in prisma/migrations


No pending migrations to apply.
➜  _official-jokes git:(main) npm start

> start
> remix-serve build

Error: Directory import '/Users/iainland/Projects/remix-palyground/examples/_official-jokes/build' is not supported resolving ES modules imported from /Users/iainland/Projects/remix-palyground/examples/_official-jokes/node_modules/@remix-run/serve/dist/cli.js
Did you mean to import "/Users/iainland/Projects/remix-palyground/examples/_official-jokes/build/index.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:259:11)
    at moduleResolve (node:internal/modules/esm/resolve:933:10)
    at defaultResolve (node:internal/modules/esm/resolve:1157:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:227:38)
    at ModuleLoader.import (node:internal/modules/esm/loader:315:34)
    at defaultImportModuleDynamically (node:internal/modules/esm/utils:194:31)
    at importModuleDynamicallyCallback (node:internal/modules/esm/utils:216:12)
    at reimportServer (/Users/iainland/Projects/remix-palyground/examples/_official-jokes/node_modules/@remix-run/serve/dist/cli.js:86:81)
    ```

@machour
Copy link
Collaborator Author

machour commented Jul 25, 2024

@imaitland This is a decision made with Brooks over discord, without being aware of the issue you're posting. Thank you for bringing it to our attention 🙏🏼

The idea was that the jokes tutorial was retried from the documentation, and we weren't interested in maintaining a legacy Remix v1 app.

CC'ing @brookslybrand to have a new look at this decision. Maybe we could spend some time fixing the example, or just add a note in its README stating that it's archived, and why.

@brookslybrand
Copy link

@imaitland This is a decision made with Brooks over discord, without being aware of the issue you're posting. Thank you for bringing it to our attention 🙏🏼

The idea was that the jokes tutorial was retried from the documentation, and we weren't interested in maintaining a legacy Remix v1 app.

CC'ing @brookslybrand to have a new look at this decision. Maybe we could spend some time fixing the example, or just add a note in its README stating that it's archived, and why.

Yep, that is correct. Someone is definitely welcome to submit a PR to fix the issue for anyone who still finds the tutorial useful, but since it is not the official tutorial the Remix team is not focused on moving it to v2.

I do like the idea @machour of adding a note to the README about why it is archived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants