Write compressed configuration [RHELDST-25461] #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start writing the configuration in compressed binary form. For more info on the motivation, see the corresponding change in exodus-lambda: release-engineering/exodus-lambda#586 Regarding the test updates in this commit, the existing fixture used to mock the DynamoDB query for config was parametrized so that existing tests would cover both binary and non-binary config cases. However, since that was previously a global autouse fixture, that would have caused every test to run twice even if the test did not deal with the config at all. To avoid this, fixtures were split into a global autouse boto session fixture (ensuring all tests still avoid any real AWS calls) and a non-autouse fixture for the DynamoDB client. The new fixture had to be explicitly added to certain tests.
rohanpm
force-pushed
the
compressed-config
branch
from
131eac1
to
db4a344
Compare
crungehottman
approved these changes
Jul 30, 2024
negillett
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more info on the motivation, see the corresponding change in
exodus-lambda:
release-engineering/exodus-lambda#586
Regarding the test updates in this commit, the existing fixture used to
mock the DynamoDB query for config was parametrized so that existing
tests would cover both binary and non-binary config cases. However,
since that was previously a global autouse fixture, that would have
caused every test to run twice even if the test did not deal with the
config at all.
To avoid this, fixtures were split into a global autouse boto session
fixture (ensuring all tests still avoid any real AWS calls) and a
non-autouse fixture for the DynamoDB client. The new fixture had to be
explicitly added to certain tests.