Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we self-shutdown if/when the Actions Runner is ephemeral? #29

Closed
ravwojdyla opened this issue Feb 24, 2023 · 2 comments
Closed

Can we self-shutdown if/when the Actions Runner is ephemeral? #29

ravwojdyla opened this issue Feb 24, 2023 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@ravwojdyla
Copy link
Contributor

#16 added the ephemeral flag, if that is the case, can we self shutdown then/if the Actions Runner exits?

@ravwojdyla ravwojdyla added enhancement New feature or request question Further information is requested labels Feb 24, 2023
@everpeace
Copy link
Contributor

if that is the case, can we self shutdown then/if the Actions Runner exits?

Yes, I confirmed the behavior in my project. I think ACTIONS_RUNNER_HOOK_JOB_COMPLETED works as expected. After the test is completed (no matter it succeded/failed/canceled), VM instance was deleted.

As you might noticed, workflow was failed/canceled before the runner fetching a job, VM will keep running, so we need to handle to delete it manually as described here.

@ravwojdyla
Copy link
Contributor Author

@everpeace right, I think this can actually be closed given the job completed hook was implemented via #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants