Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinking: Consider whether or not to use the WithBlock dial option #173

Closed
meling opened this issue Feb 4, 2024 · 1 comment · Fixed by #179
Closed

thinking: Consider whether or not to use the WithBlock dial option #173

meling opened this issue Feb 4, 2024 · 1 comment · Fixed by #179

Comments

@meling
Copy link
Member

meling commented Feb 4, 2024

Many of our examples use the WithBlock option to wait for client connections to be established. According to gRPC documentation, this is apparently an anit-pattern that may not be appropriate.

We need to understand how avoiding the WithBlock dial option will impact our use in combination with Gorums.

@aleksander-vedvik
Copy link
Collaborator

I think this might be part of a bigger problem: A config cannot be created if some of the nodes are not up and running.

I have linked a pull request that will create a config regardless of the status of the node (it will, however, try to connect to the node initially). Instead, it will try to connect to nodes (that are offline) for each message that is supposed to be sent to the nodes.

The solution passes all tests and have been tested "live" (i.e. in an actual implementation). It also removes the need for using WithBlock().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants