Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #12 #13

wants to merge 1 commit into from

Conversation

ritwickdey
Copy link

@ritwickdey ritwickdey commented Jul 26, 2019 •
edited
Loading

Fixes #12

reyronald
reyronald approved these changes Apr 4, 2020
View reviewed changes
Copy link

@reyronald reyronald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should be merged,

I noticed this as well when looking through the source

Thanks for covering that @ritwickdey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyronald reyronald reyronald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]removeEventListener will not work properly.
2 participants
@ritwickdey @reyronald