Pattern registration #678
Merged
Pattern registration #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equals/hashCode must be the ID. Otherwise, multiple exact same patterns would only occur once in the network pattern set. And when you remove a pattern at that point, even if there is another still present, the pattern would be removed entirely from the set since it's stored once because it's the same pattern, even if duplicated. This also makes it easier to cache the output resources properly.
…hint isActive and isHighlightable is checked, to avoid rendering the background on processing matrix slots which should be rendered in the scissor instead.
Use term "autocraftable" instead of "craftable" everywhere as that makes it more clear what it means.
It's noise.
It was necessary because the backing list can never contain zero of a resource, and because the grid resources used to keep a reference to the resource amount in the list. So we needed the zeroed system to properly show "0" in the gui. However, now we just query the backing list for the amount, which can be 0.
raoulvdberge
force-pushed
the
feat/GH-612/pattern-registration
branch
from
8ce475a
to
5684bb7
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #612
See #98