External Storage gametests #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starforcraft
force-pushed
the
feat/GH-248/extstoragetests
branch
2 times, most recently
from
991d8b7
to
789bed2
Compare
starforcraft
force-pushed
the
feat/GH-248/extstoragetests
branch
2 times, most recently
from
d3eff89
to
0f932cc
Compare
raoulvdberge
requested changes
Aug 11, 2024
There was a problem hiding this comment.
I'm still missing a few cases:
- changing of block state should remove from storage (e.g. removing chest block)
- changing of activeness should remove from storage
- extractions through RS seem untested?
- fuzzy mode untested
- priority untested (in combination with other RS storages)
- filter mode -> blocklist?
- access mode untested
- void excess mode
- should detect changes done to the storage itself, without interacting with RS
- insertion of a new resource
- addition of an existing resource
- partial extraction of a resource
- complete extraction of a resource
- .. all these types of changes should reflect correctly in RS (see cache impl in
ExternalStorage)
.../java/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageTest.java
Outdated
Show resolved
Hide resolved
.../java/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageTest.java
Outdated
Show resolved
Hide resolved
.../java/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageTest.java
Outdated
Show resolved
Hide resolved
starforcraft
force-pushed
the
feat/GH-248/extstoragetests
branch
7 times, most recently
from
384ff00
to
0feee57
Compare
starforcraft
force-pushed
the
feat/GH-248/extstoragetests
branch
from
0feee57
to
0e05955
Compare
raoulvdberge
requested changes
Sep 1, 2024
...a/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageItemTest.java
Outdated
Show resolved
Hide resolved
...a/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageItemTest.java
Outdated
Show resolved
Hide resolved
...a/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageItemTest.java
Outdated
Show resolved
Hide resolved
...a/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageItemTest.java
Outdated
Show resolved
Hide resolved
...a/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageItemTest.java
Outdated
Show resolved
Hide resolved
...a/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageItemTest.java
Show resolved
Hide resolved
...a/com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageItemTest.java
Outdated
Show resolved
Hide resolved
.../com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageFluidTest.java
Outdated
Show resolved
Hide resolved
.../com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageFluidTest.java
Outdated
Show resolved
Hide resolved
.../com/refinedmods/refinedstorage/common/storage/externalstorage/ExternalStorageFluidTest.java
Show resolved
Hide resolved
starforcraft
force-pushed
the
feat/GH-248/extstoragetests
branch
from
f79c8b9
to
b611347
Compare
starforcraft
force-pushed
the
feat/GH-248/extstoragetests
branch
from
b611347
to
1de2aeb
Compare
raoulvdberge
approved these changes
Sep 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gametests #248
External Storage #75